Skip to content

Conversation

@Lipata
Copy link
Member

@Lipata Lipata commented Jan 15, 2025

No description provided.

@coveralls
Copy link

coveralls commented Jan 15, 2025

Coverage Status

coverage: 70.041%. remained the same
when pulling 43a090b on nalipiev/update-dv-19
into db6d0ea on master.

@Lipata Lipata requested a review from valadzhov January 21, 2025 07:46
valadzhov
valadzhov previously approved these changes Jan 21, 2025
@valadzhov
Copy link
Contributor

The stand-alone templates are fine but the legacy ones fail with the following errors:
image

@Lipata
Copy link
Member Author

Lipata commented Jan 21, 2025

@valadzhov you will need to add all templates for both standalone and modules, not only DV.

@Lipata Lipata changed the title chore: update dv packages with v19 chore: update dv packages with v19 and add standalone false for legacy components Jan 21, 2025
@Lipata Lipata changed the title chore: update dv packages with v19 and add standalone false for legacy components chore: update dv packages with v19; standalone false for legacy components Jan 21, 2025
Copy link
Contributor

@valadzhov valadzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both stand-alone and legacy projects work.

@Lipata Lipata merged commit 7847aaa into master Jan 22, 2025
3 checks passed
@Lipata Lipata deleted the nalipiev/update-dv-19 branch January 22, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants